Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum node version in package.json #350

Closed
nichtich opened this issue May 13, 2019 · 2 comments
Closed

Specify minimum node version in package.json #350

nichtich opened this issue May 13, 2019 · 2 comments
Labels
documentation Provide sufficient documentation low priority maybe later
Milestone

Comments

@nichtich
Copy link
Member

As described here.

@nichtich nichtich added documentation Provide sufficient documentation low priority maybe later labels May 13, 2019
@nichtich nichtich added this to the 1.0.0 milestone May 13, 2019
@stefandesu
Copy link
Member

stefandesu commented Jun 25, 2019

I would suggest requiring Node.js 10 as it is the current LTS version and supported until 2021. Node.js 8 (previous LTS) is in maintenance and won't be supported after 2019.

https://nodejs.org/en/about/releases/

Edit: Cocoda works fine with Node.js 8 (8.16.0 in this case), but it comes with an older version of npm (6.4.1) which will produce a different package-lock.json than is committed in the repository. So allowing Node.js 8 would cause conflicts regarding to that.

@stefandesu
Copy link
Member

Note that the engines property in package.json 1. can't enforce using a specific Node version, and 2. doesn't even show a warning on npm i. It only shows the warning if the package is used as a dependency which is not the case for Cocoda.

We can still add it to the file to indicate the recommended Node version. I will also add it to the README and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provide sufficient documentation low priority maybe later
Projects
None yet
Development

No branches or pull requests

2 participants