-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support undo of mapping deletion and a "trash bin" for deleted mappings #354
Comments
I would try to put the trash bin in between 'feedback' and the star for favorites. |
Not sure about adding a new tab to settings just for this, but we can try to put it in the navbar. I also forgot to mention that I would add a Ctrl/Cmd + z shortcut to undo the last deletion, but depending on how you look at this it can get complicated quickly. Like, should it also undo creating or editing a mapping? Should it still undo deletion if it happened half an hour ago? And so on. Any thoughts on this? |
Not everything needs to be undoable. Registries can support version history but that would be another issue.
--
Jakob Voß via Android
|
Requires #356. |
Note: This would not be a traditional "undo" of deletion of a mapping, but rather a "restore" in the sense that it will be saved again. This means that it will get the latest modified date as well as a new URI (in case of jskos-server at least). I don't think that this is a problem, but it's a caveat to keep in mind. |
jskos-server now allows a pre-given URI when POSTing a mapping, so that at least the URI can remain the same. Local mappings already have support for this. |
Please try out the first implementation of this idea in dev. Some notes:
|
When a mapping is deleted, there is a message "Mapping was deleted." That message should 1. stay a bit longer than other messages, and 2. include an undo button to restore that mapping in case it was deleted accidentally.
Additionally, recently deleted mappings could be kept in a "trash bin" from which they can be restored later if necessary. This trash bin should be either restricted by time (only keep the recent 7 days, for example), and/or by number of deleted mappings (only keep the last 10 deleted mappings).
The text was updated successfully, but these errors were encountered: