Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes, loading doesn't stop -> improve internal error handling #399

Closed
stefandesu opened this issue Jun 6, 2019 · 1 comment
Closed
Labels
bug Something is broken
Milestone

Comments

@stefandesu
Copy link
Member

Unfortunately, I couldn't find a way to reproduce this yet, but at the workshop yesterday we had multiple occasions where the loading doesn't stop. Once it happened on my machine, but only in Safari where I couldn't see the place in code where it happened, but it was some uncaught promise rejection.

A way to improve this would be to improve error handling to make sure that all promise rejections are caught properly and print helpful information on the console if possible.

@stefandesu stefandesu added the bug Something is broken label Jun 6, 2019
@stefandesu stefandesu added this to the 0.9.2 milestone Jun 6, 2019
stefandesu added a commit that referenced this issue Jun 7, 2019
@stefandesu
Copy link
Member Author

Not sure if it will fix this particular error, but I added some error catching at various places where it could have failed. I'm closing this for now, we should open a separate issue when we are able to find a way to reproduce the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

No branches or pull requests

1 participant