Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better document mapping types #404

Closed
nichtich opened this issue Jun 6, 2019 · 5 comments
Closed

Better document mapping types #404

nichtich opened this issue Jun 6, 2019 · 5 comments
Labels
documentation Provide sufficient documentation user experience Usage should be fun and easy
Milestone
0.9.3

Comments

@nichtich
Copy link
Member

nichtich commented Jun 6, 2019

Especially >, <, and -> need better names, and a short description both in the UI and in the manual.
@nichtich nichtich added user experience Usage should be fun and easy documentation Provide sufficient documentation labels Jun 6, 2019
@stefandesu
Copy link
Member

The mapping types are coming from Wikidata, so should the names be adjusted there, or should we better split off from Wikidata again?

See gbv/jskos-tools#9 and your commit.

@nichtich nichtich modified the milestones: 0.9.2, 0.9.3 Jun 6, 2019
@nichtich
Copy link
Member Author

nichtich commented Jun 6, 2019 •
edited
Loading

I updated the labels and added definition (to show together with the labels on mouseover) in jskos-tools 0.2.7. The definition should also be shown in Mapping-Details modal

@nichtich
Copy link
Member Author

nichtich commented Jun 7, 2019

The tooltip in mapping search show English names also if user interface language is set to German. The definition could be appended with : to the label.

@stefandesu
Copy link
Member

Do the definitions need to be added in Mapping Search as well? My suggestion would be to only add them in Mapping Editor.

stefandesu added a commit that referenced this issue Jun 7, 2019
@stefandesu
Show proper prefLabel for mapping types (#404)
fb45240
@nichtich
Copy link
Member Author

Do the definitions need to be added in Mapping Search as well? My suggestion would be to only add them in Mapping Editor.
It's enough to show them in mapping editor.

stefandesu added a commit that referenced this issue Jun 12, 2019
@stefandesu
MappingTypeSelection: Add type definition to tooltip (#404)
be2b720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Provide sufficient documentation user experience Usage should be fun and easy
Projects
None yet
Milestone
0.9.3
Development

No branches or pull requests
2 participants
@nichtich @stefandesu