Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize Settings #428

Closed
stefandesu opened this issue Jun 21, 2019 · 1 comment
Closed

Reorganize Settings #428

stefandesu opened this issue Jun 21, 2019 · 1 comment
Milestone
1.0.0

Comments

@stefandesu
Copy link
Member

Also, delete local mappings should clear mapping trash as well.
@stefandesu stefandesu added this to the 1.0.0 milestone Jun 21, 2019
stefandesu added a commit that referenced this issue Jun 24, 2019
@stefandesu
Settings: Clear trash when deleting all local mappings (#428)
945e4e3
@stefandesu
Copy link
Member Author

Theoretically, we could remove all remaining three checkboxes from "Layout" and add them to a settings popup in the respective components (ConceptDetail and ConceptList). But then every component in the application would have a settings button in the top left, not sure what I think about that (maybe we could make it almost transparent so that it's less distracting). Also, if we do that, we'll have "Language" and "Reset card sizes" left, not sure if those need their own tab in settings, but I'm also not sure where else to put them.

I think the other tabs besides Layout are fine for now.

stefandesu added a commit that referenced this issue Jun 24, 2019
@stefandesu
Settings: Rename tab "Accounts" to "Account" (#428)
162fd0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@stefandesu