Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary changes for Wikidata write access support #445

Closed
5 tasks done
stefandesu opened this issue Aug 14, 2019 · 1 comment
Closed
5 tasks done

Necessary changes for Wikidata write access support #445

stefandesu opened this issue Aug 14, 2019 · 1 comment
Labels
feature Additional functionality
Milestone

Comments

@stefandesu
Copy link
Member

stefandesu commented Aug 14, 2019

Write access via wikidata-jskos is ready to be added. It works out of the box, but there are some necessary adjustments needed in Cocoda before shipping the feature:

  • Adjust config
  • Wikidata mappings don't include a creator. Because of that, editing a mapping will always show that it has changed (because it assumes the new creator). We need some kind of exception for that.
  • Wikidata only allows mappings from Wikidata to something else (and also only to supported schemes). We should at least make sure that there is an option saying that only WD -> X mappings are supported. Even better would be to load the list of supported schemes and check against that.
  • wikidata-jskos will return a new config key config.auth.identityProviders which is a list of possible identity providers it can use (in this case only "wikidata"). Cocoda should take this into account when checking whether the user is authorized for Wikidata.
  • Bug: If a Wikidata mapping exists between the currently selected concepts, it is somehow shown twice (seems to be a Cocoda issue, not wikidata-jskos). Edit: It's a bug in wikidata-jskos related to having both from and to as parameters. Will be fixed there.
@stefandesu stefandesu added the feature Additional functionality label Aug 14, 2019
@stefandesu stefandesu added this to the 1.1.0 milestone Aug 14, 2019
stefandesu added a commit to gbv/wikidata-jskos that referenced this issue Aug 14, 2019
@stefandesu
Copy link
Member Author

Implemented on a separate branch, soon to be merged into dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Additional functionality
Projects
None yet
Development

No branches or pull requests

1 participant