Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MappingNavigator: Filter reconciliation sources #449

Closed
nichtich opened this issue Aug 19, 2019 · 2 comments
Closed

MappingNavigator: Filter reconciliation sources #449

nichtich opened this issue Aug 19, 2019 · 2 comments
Labels
feature Additional functionality user experience Usage should be fun and easy
Milestone
1.1.0

Comments

@nichtich
Copy link
Member

Add an option to hide mappings suggested from reconciliation if they are already stored in the current mapping registry. Example:

image

The mapping from Q1144457 Quantenphysik to GND 4266670-3 Quantenphysik is shown twice without the suggested filter option.
@nichtich nichtich added user experience Usage should be fun and easy feature Additional functionality labels Aug 19, 2019
@stefandesu
Copy link
Member

The same applies for all other recommendations, right? It would be easier to implement this for the whole group of registries.

Also, they will only be hidden if they already exist in the currently selected registry, right?

I would use the memberIdentifier for this because the mapping type is not relevant.

@stefandesu stefandesu added this to the 1.1.0 milestone Aug 19, 2019
@nichtich
Copy link
Member Author

Yes, yes, and yes.

stefandesu added a commit that referenced this issue Aug 28, 2019
@stefandesu
MappingNavigator: Filter automatic mappings (#449)
555f4cc 
If a mapping suggestion is already available as a mapping in the currently selected registry, hide it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Additional functionality user experience Usage should be fun and easy
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@nichtich @stefandesu