Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support selecting concept types #57

Closed
nichtich opened this issue Jun 20, 2018 · 7 comments
Closed

Support selecting concept types #57

nichtich opened this issue Jun 20, 2018 · 7 comments
Labels
feature Additional functionality KENOM Required for KENOM instance
Milestone

Comments

@nichtich
Copy link
Member

Some vocabularies group their concepts into concept types - see for instance "Entitätentypen" at http://gnd.eurospider.com/ for GND and table vs. class entries for DDC. RVK classes should also get types for instance to sort out classes about particular authors.

This feature requires an additional endpoint for suggest services to return a list of types. Types could also be hard-coded in config, e.g. for https://ws.gbv.de/suggest/gnd/:

{
    "voc": [ {
      "uri": "http://bartoc.org/en/node/430",
      "prefLabel": { "de": "Gemeinsame Normdatei" },
      "notation": ["GND"]
    } ],
    "data": "http://coli-conc.gbv.de/services/gnd.php",
    "suggest": "https://ws.gbv.de/suggest/gnd/?searchterm={searchTerms}&type={type}",
    "types":[
  {
    "uri": "http://d-nb.info/standards/elementset/gnd#DifferentiatedPerson",
    "prefLabel": {
      "de": "Person",
      "en": "person"
    }
  },
  {
    "uri": "http://d-nb.info/standards/elementset/gnd#PlaceOrGeographicName",
    "prefLabel": {
      "de": "Geografikum",
      "en": "place"
    }
  },
  {
    "uri": "http://d-nb.info/standards/elementset/gnd#CorporateBody",
    "prefLabel": {
      "de": "Organisation",
      "en": "organization"
    }
  },
  {
    "uri": "http://d-nb.info/standards/elementset/gnd#SubjectHeading",
    "prefLabel": {
      "de": "Sachbegriff",
      "en": "subject"
    }
  }
]
}
@nichtich nichtich added feature Additional functionality backend Requires work on the backend labels Jun 20, 2018
@StiftungAusNachlass
Copy link
Member

I added https://ws.gbv.de/suggest/gnd/types
The list is hardcoded.. We could add the list for exact_types too, if you need it.

@nichtich nichtich added this to the 1.0.0 milestone Jul 6, 2018
@nichtich nichtich modified the milestones: 1.0.0, 0.7.0 Oct 25, 2018
@nichtich nichtich removed the backend Requires work on the backend label Oct 25, 2018
@nichtich
Copy link
Member Author

Practical mapping against GND is impossible without this feature, so better implement it earlier.

@nichtich
Copy link
Member Author

See http://blog.lobid.org/2018/03/20/gnd-class-hierarchy.html for a more detailed classification of GND concept types, including occurrence counts.

@StiftungAusNachlass
Copy link
Member

Thanks for the extended description of the requirements. The service already understood the type-parameter by URI, but only with delimiter ',' and not by '|'. I've added the pipe as delimiterchar and now the calls are working.

@stefandesu stefandesu modified the milestones: 0.7.0, 0.6.0 Nov 12, 2018
@nichtich nichtich added the KENOM Required for KENOM instance label Nov 12, 2018
@stefandesu
Copy link
Member

The first version of this is now implemented. If concept types are available (currently only for GND), they are shown in ItemDetail when the concept scheme is chosen. There, you can choose which types are used in ConceptSearch.

SchemeDetail might not be the right place for this though. Also, right now it's not clear that the selection will influence the search results because there is no explanation. On top of that, the feature needs to be tested (it worked for the examples at least).

@stefandesu
Copy link
Member

d0de981 moved the filter from SchemeDetail into ConceptSearch which is a much better place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Additional functionality KENOM Required for KENOM instance
Projects
None yet
Development

No branches or pull requests

3 participants