-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support selecting concept types #57
Comments
I added https://ws.gbv.de/suggest/gnd/types |
Practical mapping against GND is impossible without this feature, so better implement it earlier. |
See http://blog.lobid.org/2018/03/20/gnd-class-hierarchy.html for a more detailed classification of GND concept types, including occurrence counts. |
DANTE requires extension to accept for instance equivalent to https://ws.gbv.de/suggest/gnd/?searchterm=Helms&type=CorporateBody,SubjectHeading&count=10 |
Thanks for the extended description of the requirements. The service already understood the type-parameter by URI, but only with delimiter ',' and not by '|'. I've added the pipe as delimiterchar and now the calls are working. |
The first version of this is now implemented. If concept types are available (currently only for GND), they are shown in ItemDetail when the concept scheme is chosen. There, you can choose which types are used in ConceptSearch. SchemeDetail might not be the right place for this though. Also, right now it's not clear that the selection will influence the search results because there is no explanation. On top of that, the feature needs to be tested (it worked for the examples at least). |
d0de981 moved the filter from SchemeDetail into ConceptSearch which is a much better place. |
Some vocabularies group their concepts into concept types - see for instance "Entitätentypen" at http://gnd.eurospider.com/ for GND and table vs. class entries for DDC. RVK classes should also get types for instance to sort out classes about particular authors.
This feature requires an additional endpoint for suggest services to return a list of types. Types could also be hard-coded in config, e.g. for https://ws.gbv.de/suggest/gnd/:
The text was updated successfully, but these errors were encountered: