Skip to content

Commit

Permalink
update linregress in frame-benchmarking to 0.5.1 (paritytech#13310)
Browse files Browse the repository at this point in the history
* update nalgebra in frame-benchmarking to 0.5.0

* upgrade to 0.5.1 to incorporate upstream fix in linregress
  • Loading branch information
sam0x17 authored and ark0f committed Feb 27, 2023
1 parent 4b52cb1 commit ec50223
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 26 deletions.
58 changes: 34 additions & 24 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frame/benchmarking/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ targets = ["x86_64-unknown-linux-gnu"]

[dependencies]
codec = { package = "parity-scale-codec", version = "3.2.2", default-features = false }
linregress = { version = "0.4.4", optional = true }
linregress = { version = "0.5.1", optional = true }
log = { version = "0.4.17", default-features = false }
paste = "1.0"
scale-info = { version = "2.1.1", default-features = false, features = ["derive"] }
Expand Down
2 changes: 1 addition & 1 deletion frame/benchmarking/src/analysis.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ fn raw_linear_regression(
data.extend(xs);
}
let model = linregress::fit_low_level_regression_model(&data, ys.len(), x_vars + 2).ok()?;
Some((model.parameters[0], model.parameters[1..].to_vec(), model.se))
Some((model.parameters()[0], model.parameters()[1..].to_vec(), model.se().to_vec()))
}

fn linear_regression(
Expand Down

0 comments on commit ec50223

Please sign in to comment.