Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust paramer type in AddBreadcrumb #1000

Merged

Conversation

jairbubbles
Copy link
Contributor

@jairbubbles jairbubbles commented May 17, 2021

Always better to use a concrete type, also it's now consistent with the other extension method.

@Tyrrrz
Copy link
Contributor

Tyrrrz commented May 20, 2021

Looks good @jairbubbles.
Can you please add a quick changelog entry? Should be something like this (in ## Unreleased section):

- Adjust paramer type in `AddBreadcrumb` to use `IReadOnlyDictionary<...>` instead of `Dictionary<...>` [#1000](https://github.com/getsentry/sentry-dotnet/pull/1000)

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #1000 (dd8d3a1) into main (984b210) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1000   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files         184      184           
  Lines        5903     5903           
  Branches     1454     1454           
=======================================
  Hits         4795     4795           
  Misses        691      691           
  Partials      417      417           
Impacted Files Coverage Δ
src/Sentry/IHasBreadcrumbs.cs 44.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984b210...dd8d3a1. Read the comment docs.

@jairbubbles
Copy link
Contributor Author

@Tyrrrz Done!

@Tyrrrz
Copy link
Contributor

Tyrrrz commented May 20, 2021

Thanks!

@Tyrrrz Tyrrrz enabled auto-merge (squash) May 20, 2021 18:33
@Tyrrrz Tyrrrz merged commit 3c5db79 into getsentry:main May 20, 2021
@bruno-garcia
Copy link
Member

Thanks @jairbubbles !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants