Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging and additional fallback for installation ID #1103

Merged
merged 6 commits into from
Jul 10, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jul 2, 2021

I don't know what other logs I can add, this sequence is incredibly trivial. I did add Environment.MachineName as fallback, which should hopefully work x-platform.

@Tyrrrz Tyrrrz requested a review from bruno-garcia as a code owner July 2, 2021 19:18
@Tyrrrz Tyrrrz force-pushed the enhanced-logging-installation-id branch from 6c77315 to 61b6aae Compare July 2, 2021 19:20
@Tyrrrz Tyrrrz requested a review from bruno-garcia July 5, 2021 19:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021

Codecov Report

Merging #1103 (72b2f9e) into main (4fe2084) will increase coverage by 0.12%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   80.84%   80.97%   +0.12%     
==========================================
  Files         195      195              
  Lines        6400     6406       +6     
  Branches     1413     1414       +1     
==========================================
+ Hits         5174     5187      +13     
+ Misses        764      755       -9     
- Partials      462      464       +2     
Impacted Files Coverage Δ
src/Sentry/GlobalSessionManager.cs 66.66% <87.50%> (ø)
src/Sentry/Internal/Extensions/HashExtensions.cs 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe2084...72b2f9e. Read the comment docs.

@bruno-garcia bruno-garcia enabled auto-merge (squash) July 10, 2021 14:06
@bruno-garcia bruno-garcia changed the title Add additional logging and additional fallback for installation ID logging and additional fallback for installation ID Jul 10, 2021
@bruno-garcia bruno-garcia merged commit 733245e into main Jul 10, 2021
@bruno-garcia bruno-garcia deleted the enhanced-logging-installation-id branch July 10, 2021 17:56
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- logging and additional fallback for installation ID([#1103](https://github.com/getsentry/sentry-dotnet/pull/1103))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 72b2f9e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants