Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max breadcrumbs limit when MaxBreadcrumbs is zero or lower #1145

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

lucas-zimerman
Copy link
Collaborator

Previously, it didn't matter the MaxBreadcrumb value, it would always be able to insert at least one breadcrumb because _breadcrumbs.Enqueue(breadcrumb); was out of any validation.

Close #1110.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #1145 (785f188) into main (68970d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1145   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files         203      203           
  Lines        6674     6675    +1     
  Branches     1476     1477    +1     
=======================================
+ Hits         5378     5379    +1     
  Misses        816      816           
  Partials      480      480           
Impacted Files Coverage Δ
src/Sentry/Scope.cs 93.89% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68970d7...785f188. Read the comment docs.

@bruno-garcia bruno-garcia merged commit b08a831 into main Jul 26, 2021
@bruno-garcia bruno-garcia deleted the fix/max-breadcrumb-not-respected branch July 26, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaxBreadcrumbs = 0 doesn't work
4 participants