Fix/sql client db name #2418
Merged
Fix/sql client db name #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectionId and CommandId
… EF diagnostic events
Co-authored-by: Matt Johnson-Pint <matt.johnson-pint@sentry.io>
…ntry/sentry-dotnet into fix/db-spans-not-finishing
…ly compare TimeStamps
… as a description
…o fix/db-spans-presentation
…gnostic listeners
jamescrosswell
requested review from
mattjohnsonpint and
bitsandfoxes
as code owners
mattjohnsonpint
approved these changes
Jun 12, 2023
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Fix/sql client db name ([#2418](https://github.com/getsentry/sentry-dotnet/pull/2418))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on Fix/DB Connection spans presented poorly #2409.
Ensures the
db.nameis recorded for Query/Command spans when usingSqlClient(the same way it works for Entity Framework).