Feat/4.0.0 deprecate IHasDistribution

CHANGELOG.md

@@ -14,6 +14,10 @@ without native/platform specific bindings and SDKs. See [this ticket for more de
 
 - Drop .NET 6 Mobile in favor of .NET 7 ([#2624](https://github.com/getsentry/sentry-dotnet/pull/2604))
 
+API Changes:
+
+- Removed IHasDistribution ([#2660](https://github.com/getsentry/sentry-dotnet/pull/2660))
+
 ### Features
 
 - Sentry tracing middleware now gets configured automatically ([#2602](https://github.com/getsentry/sentry-dotnet/pull/2602))

src/Sentry/IEventLike.cs

@@ -5,6 +5,11 @@ namespace Sentry;
 /// </summary>
 public interface IEventLike : IHasBreadcrumbs, IHasTags, IHasExtra
 {
+    /// <summary>
+    /// The release distribution of the application.
+    /// </summary>
+    public string? Distribution { get; set; }
+
     /// <summary>
     /// Sentry level.
     /// </summary>

src/Sentry/Internal/Enricher.cs

@@ -61,7 +61,7 @@ public void Apply(IEventLike eventLike)
         eventLike.Release ??= _options.SettingLocator.GetRelease();
 
         // Distribution
-        eventLike.WithDistribution(_ => _.Distribution ??= _options.Distribution);
+        eventLike.Distribution ??= _options.Distribution;
 
         // Environment
         eventLike.Environment ??= _options.SettingLocator.GetEnvironment();

src/Sentry/Internal/NoOpTransaction.cs

@@ -25,6 +25,12 @@ public bool? IsParentSampled
         set { }
     }
 
+    public string? Distribution
+    {
+        get => string.Empty;
+        set { }
+    }
+
     public SentryLevel? Level
     {
         get => default;

src/Sentry/Scope.cs

@@ -11,7 +11,7 @@ namespace Sentry;
 /// Scope data is sent together with any event captured
 /// during the lifetime of the scope.
 /// </remarks>
-public class Scope : IEventLike, IHasDistribution
+public class Scope : IEventLike
 {
     internal SentryOptions Options { get; }
 
@@ -435,7 +435,7 @@ public void Apply(IEventLike other)
 
         other.Platform ??= Platform;
         other.Release ??= Release;
-        other.WithDistribution(_ => _.Distribution ??= Distribution);
+        other.Distribution ??= Distribution;
         other.Environment ??= Environment;
         other.TransactionName ??= TransactionName;
         other.Level ??= Level;

src/Sentry/SentryEvent.cs

@@ -11,7 +11,7 @@ namespace Sentry;
 /// </summary>
 /// <seealso href="https://develop.sentry.dev/sdk/event-payloads/" />
 [DebuggerDisplay("{GetType().Name,nq}: {" + nameof(EventId) + ",nq}")]
-public sealed class SentryEvent : IEventLike, IJsonSerializable, IHasDistribution
+public sealed class SentryEvent : IEventLike, IJsonSerializable
 {
     private IDictionary<string, string>? _modules;
 

src/Sentry/Transaction.cs

@@ -9,7 +9,7 @@ namespace Sentry;
 /// <summary>
 /// Sentry performance transaction.
 /// </summary>
-public class Transaction : ITransactionData, IJsonSerializable, IHasDistribution, IHasTransactionNameSource, IHasMeasurements
+public class Transaction : ITransactionData, IJsonSerializable, IHasTransactionNameSource, IHasMeasurements
 {
     /// <summary>
     /// Transaction's event ID.
@@ -244,7 +244,7 @@ public Transaction(ITransaction tracer)
         Operation = tracer.Operation;
         Platform = tracer.Platform;
         Release = tracer.Release;
-        Distribution = tracer.GetDistribution();
+        Distribution = tracer.Distribution;
         StartTimestamp = tracer.StartTimestamp;
         EndTimestamp = tracer.EndTimestamp;
         Description = tracer.Description;

src/Sentry/TransactionTracer.cs

@@ -7,7 +7,7 @@ namespace Sentry;
 /// <summary>
 /// Transaction tracer.
 /// </summary>
-public class TransactionTracer : ITransaction, IHasDistribution, IHasTransactionNameSource, IHasMeasurements
+public class TransactionTracer : ITransaction, IHasTransactionNameSource, IHasMeasurements
 {
     private readonly IHub _hub;
     private readonly SentryOptions? _options;