Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Metrics.Set now accepts string as value #3092

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jan 29, 2024

From the updated dev docs: https://develop.sentry.dev/sdk/metrics/#sets Set should accept strings as value.
With this PR we're vendoring in part of force's Crc32.NET implementation because there is not anything built-in that I could find.

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b832505

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (467676e) 76.53% compared to head (b832505) 76.11%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Sentry/Force.Crc32/Crc32Algorithm.cs 9.09% 38 Missing and 2 partials ⚠️
src/Sentry/Force.Crc32/SafeProxy.cs 44.44% 19 Missing and 1 partial ⚠️
src/Sentry/DisabledMetricAggregator.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3092      +/-   ##
==========================================
- Coverage   76.53%   76.11%   -0.42%     
==========================================
  Files         355      357       +2     
  Lines       13381    13465      +84     
  Branches     2656     2669      +13     
==========================================
+ Hits        10241    10249       +8     
- Misses       2460     2533      +73     
- Partials      680      683       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Jan 29, 2024

@bitsandfoxes did you see System.IO.Hashing.Crc32?

I guess that comes with a dependency on the System.IO.Hashing NuGet package...

@bitsandfoxes
Copy link
Contributor Author

@bitsandfoxes did you see System.IO.Hashing.Crc32?

I guess that comes with a dependency on the System.IO.Hashing NuGet package...

Yes. Not wanting to take on the dependency is the reason why we're vendoring it in.

@bitsandfoxes bitsandfoxes merged commit 8bc2e51 into main Jan 30, 2024
20 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/metrics-set branch January 30, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants