Suppress P/Invoke warning for GetWindowThreadProcessId in UWP #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
approved these changes
May 16, 2024
| // GetWindowThreadProcessId is only available in the Windows SDK, so trying to call this from UWP apps will fail. | ||
| // We wrap use of this in a try/catch as a workaround. However, we need `ExactSpelling = true` here to suppress | ||
| // warnings about the use of this API when compiling UWP applications. | ||
| [DllImport("user32.dll", CharSet = CharSet.Auto, SetLastError = true, ExactSpelling = true)] |
There was a problem hiding this comment.
I get that the warning stated
Please make sure the P/Invoke either points to a Windows API allowed in UWP applications, or a native DLL that is part of the package.
If for some reason your P/Invoke does not satisfy those requirements, please use [DllImport(ExactSpelling=true) to indicate that you understand the implications of using non-UWP A
but isn't adding ExactSpelling=true more a "Trust me, I know what I'm doing" and not a suppression of a warning?
But does it make a difference? The comment explains it.
There was a problem hiding this comment.
I published a new Sentry.nupkg file after making this change, referenced it in a UWP solution and rebuilt... yes the warnings go away if you do that. It's a very bizarre way to suppress warnings if you ask me (thus the code comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3249