All exceptions are now added as breadcrumbs on future events

[jamescrosswell]

Resolves #3444

This is a bit redundant if tracing is enabled. In that case there is a notification at the top of the event informing you of any other exceptions(s) that have been encountered within the same trace:

[bitsandfoxes]

Just double-checking: If I've got my log-level set to Warning and the SDK creates an event out of a log warning:

• The minimum level is reached and the integration captures an event, skipping the breadcrumb creation
• From the logging integration we get here
• There was no exception - we bail early
• Warnings don't get added as breadcrumbs by neither the logging integration nor the core SDK?

[jamescrosswell]

Nice catch... have pushed a new commit to fix (the SentryLogger and SentrySink now do create breadcrumbs for events, if no exceptions are associated with those events).

I think that's the correct behaviour since CaptureEvent is also used by CaptureMessage (and I assume we don't want to automatically add breadcrumbs for calls to CaptureMessage):

sentry-dotnet/src/Sentry/HubExtensions.cs

Line 221 in f22c2d4

return hub.CaptureEvent(sentryEvent, configureScope);

[jamescrosswell]

I noticed this in the NLog options:

sentry-dotnet/src/Sentry.NLog/SentryNLogOptions.cs

Lines 47 to 51 in 57feab3

	/// <summary>
	/// Determines whether or not to include event-level data as data in breadcrumbs for future errors.
	/// Defaults to <see langword="false" />.
	/// </summary>
	public bool IncludeEventDataOnBreadcrumbs { get; set; } = false;

Initially I thought that was related to this ticket but actually it's just confusion over the use of the word "Event" which, in this context, means the logging event (not a sentry event). This settings determines whether "Logging Event" data gets added as context for breadcrumbs:

sentry-dotnet/src/Sentry.NLog/SentryTarget.cs

Lines 418 to 432 in 2ef9f80

	if (IncludeEventDataOnBreadcrumbs)
	{
	if (shouldIncludeProperties)
	{
	var contextProps = GetAllProperties(logEvent);
	data ??= new Dictionary<string, string>(contextProps.Count);
	foreach (var contextProp in contextProps)
	{
	if (contextProp.Value?.ToString() is { } value)
	{
	data.Add(contextProp.Key, value);
	}
	}
	}
	}

So, back to the original plan.

[bitsandfoxes]

Nice!