Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator flag set to false when running on a iOS Simulator #189

Closed
bruno-garcia opened this issue May 18, 2021 · 2 comments
Closed

Simulator flag set to false when running on a iOS Simulator #189

bruno-garcia opened this issue May 18, 2021 · 2 comments
Assignees
@semuserable
Labels
Bug Something isn't working

Comments

@bruno-garcia
Copy link
Member

The PR #184 fixed a bug but introduced a new one.
When isEditor is false, it doesn't necessarily mean it's simulator false. The game could be running on an Android emulator or an iOS simulator.

The logic there needs to be: If it's in the editor, then we know it's simulator=true. Otherwise, we can't safely set a value for simulator.
@bruno-garcia bruno-garcia added the Bug Something isn't working label May 18, 2021
@bitsandfoxes
Copy link
Contributor

When we can't safely set a value we don't? Or do we fall back to false?

@semuserable semuserable self-assigned this May 19, 2021
@bitsandfoxes
Copy link
Contributor

closed by #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@semuserable semuserable

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bruno-garcia @semuserable @bitsandfoxes