Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag simulator based on Application.isEditor #184

Merged
merged 3 commits into from
May 18, 2021
Merged

Conversation

semuserable
Copy link
Contributor

No description provided.

@bitsandfoxes
Copy link
Contributor

Since IApplication now has a concept of IsSimulator:

: Application.isEditor // TODO: Should we move it out and use via IApplication something?

// TODO: Move it out and use via IApplication

I think those would be fixed too?

@semuserable
Copy link
Contributor Author

Tbh, not sure about SentryUnityOptions, because we have IApplication dependency only on integrations and not on SentryUnityOptions construction itself.

@bruno-garcia
Copy link
Member

Tbh, not sure about SentryUnityOptions, because we have IApplication dependency only on integrations and not on SentryUnityOptions construction itself.

Ideally we'd decouple those but on a follow up PR woudd be fine. That's not high priority given we're aiming at shipping 0.1.0 asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants