Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper sdk name reporting for sentry event; test #111

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

semuserable
Copy link
Contributor

@semuserable semuserable commented Apr 16, 2021

  • check version numbers and naming for package too. I guess the version should be different
  • removed nullability for SentryEvent and Sdk based on dotnet Sentry SDK, it's still on ISentryEventProcessor, but from usage perspective it's not nullable

closes #96

@semuserable
Copy link
Contributor Author

semuserable commented Apr 16, 2021

@bruno-garcia ok, question for this danger thing. I need to add the exact wording from commit message into CHANGELOG.md? Otherwise an error? I added it already to Unreleased part (- Proper sdk name reporting for sentry event (#96)), but it fails.

@bruno-garcia
Copy link
Member

The comment posted on the PR has some instructions if you click onit:

image

The problem is that the PR number is #111 not #96

src/Sentry.Unity/UnityEventProcessor.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/UnityEventProcessor.cs Outdated Show resolved Hide resolved
@semuserable
Copy link
Contributor Author

semuserable commented Apr 16, 2021

@bruno-garcia thanks! All comments applied.

@bruno-garcia bruno-garcia merged commit cb9e03a into main Apr 16, 2021
@bruno-garcia bruno-garcia deleted the feature/sdk-name-event branch April 16, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events should report sdk.name sentry.dotnet.unity
2 participants