fix: Reinstall native backend #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munkiki7
approved these changes
Apr 5, 2024
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Reinstall native backend ([#1603](https://github.com/getsentry/sentry-unity/pull/1603))If none of the above apply, you can opt out of this check by adding |
|
Is there a ticket this is related to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure (yet) when that happened but Unity is overwriting the signal handler in newer versions. This prevents
sentry-nativefrom capturing native crashes.We have a similar situation on Android where we reinstall the backend to take back control so I'm taking the same approach to resolve this.
An open TODO: We have checks in CI specifically to make sure that does not break. Why does CI pass?