Improve C++ exceptions stacktrace on iOS #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That does |
All native plugin files in the Unity Project (in the Assets directory, as well as in Packages) will be linked to UnityFramework target, and will be properly handled. |
There was a problem hiding this comment.
So this gets copied to the generated Xcode project by Unity. Any chance this causes issues with Sentry disabled? The includes look fine to me.
There was a problem hiding this comment.
Just checked. And we also copy the no-op bridge over. So it's fine.
bitsandfoxes
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1628
There are still some cases that are not covered by this fix.
If the exception is thrown not from UnityFramework, but from another library, the hook will not be called.
The details can be found in the conversation of the issue.