Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SentryInitialization prevents codestripping of Init #285

Merged
merged 4 commits into from
Aug 23, 2021

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Aug 20, 2021

Because we moved SentryInitialization out of our DLL to compile with the game and it was not covered by our link.xml the code stripper just gets rid of ot.

@bitsandfoxes bitsandfoxes self-assigned this Aug 20, 2021
@bitsandfoxes bitsandfoxes changed the title fix: Added attribute to prevent codestripping of init fix: Added attribute to SentryInitialization to prevent codestripping of Init Aug 23, 2021
@bruno-garcia bruno-garcia changed the title fix: Added attribute to SentryInitialization to prevent codestripping of Init fix: SentryInitialization prevents codestripping of Init Aug 23, 2021
@bruno-garcia bruno-garcia merged commit 2e735bd into main Aug 23, 2021
@bruno-garcia bruno-garcia deleted the fix/init-code-stripping branch August 23, 2021 13:30
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- SentryInitialization prevents codestripping of Init ([#285](https://github.com/getsentry/sentry-unity/pull/285))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2afe0e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants