Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed link.xml #707

Merged
merged 8 commits into from
Apr 28, 2022
Merged

feat: Removed link.xml #707

merged 8 commits into from
Apr 28, 2022

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Apr 26, 2022

Resolves #287

Hypothesis: We required the link.xml back when the SDK was self-initializing from within the DLL. Since we now compile SentryInitialization with the actual project we no longer require it.

We added aliasing but we never updated the contents of the link.xml and it worked regardless.

To discuss: How does this change affect users updating the SDK? Should we look for and delete the file in their project?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Removed link.xml ([#707](https://github.com/getsentry/sentry-unity/pull/707))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d6bae7b

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be brave

@bitsandfoxes bitsandfoxes merged commit 935d9d7 into main Apr 28, 2022
@bitsandfoxes bitsandfoxes deleted the fix/remove-linkxml branch April 28, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated link.xml would not override existing one
3 participants