feat: setup wizard #780
feat: setup wizard #780
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- setup wizard ([#780](https://github.com/getsentry/sentry-unity/pull/780))If none of the above apply, you can opt out of this check by adding |
|
If there is only one org, one project |
vaind
force-pushed
the
feat/wizard
branch
3 times, most recently
from
64e53c2
to
0fb1956
Compare
| @@ -6,7 +6,11 @@ namespace Sentry.Unity.Editor.ConfigurationWindow | |||
| { | |||
| public sealed class SentryTestWindow : SentryWindow, IDisposable | |||
| { | |||
| protected override string SentryOptionsAssetName { get; } = Path.GetRandomFileName(); | |||
| public SentryTestWindow() | |||
There was a problem hiding this comment.
@bitsandfoxes is this supposed to be in the test project instead?
There was a problem hiding this comment.
Yes, we probably should move it into Sentry.Unity.Editor.Tests.
There was a problem hiding this comment.
actually... not moved - some editor tests fail after moving - leaving as is and if this bothers anyone too much, please create an issue
| .Prepend(firstEntry).ToArray()); | ||
| } | ||
|
|
||
| if (_projectSelected != 0) |
There was a problem hiding this comment.
Lets just always add the token, we just need to tell the user not to make the SentryCliOptions asset public
There was a problem hiding this comment.
Lets just always add the token, we just need to tell the user not to make the SentryCliOptions asset public
I'll add a note here. Also, what about auto-creating a changed my mind, probably a bad idea.gitignore alongside the SentryCliOptions.asset?
vaind
force-pushed
the
feat/wizard
branch
2 times, most recently
from
55253e5
to
7b1d098
Compare
There was a problem hiding this comment.
I can't approve my own PR, but great stuff @vaind ! thank you
| @@ -6,7 +6,11 @@ namespace Sentry.Unity.Editor.ConfigurationWindow | |||
| { | |||
| public sealed class SentryTestWindow : SentryWindow, IDisposable | |||
| { | |||
| protected override string SentryOptionsAssetName { get; } = Path.GetRandomFileName(); | |||
| public SentryTestWindow() | |||
There was a problem hiding this comment.
Yes, we probably should move it into Sentry.Unity.Editor.Tests.
|
Thanks for transforming a rough idea into something amazing guys! |
The goal is to have an onboarding flow that will have the user hit Sentry, select an org and project, and will pre-populate the DSN and the Sentry CLI options for symbol upload.
Edit @vaind: cleaned this up somewhat, resolved TODOs and usability issues.
Remaining TODO: tests 😱
Basic workflow:
First draft does (outdated):
Opens the browser:
prepopulates orgs:
Then projects:
After selecting, the normal window shows up. With DSN, Org and Proj slug and Auth token.