Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proguard support #844

Merged
merged 7 commits into from
Jun 23, 2022
Merged

feat: proguard support #844

merged 7 commits into from
Jun 23, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jun 23, 2022

closes #797

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against caae6de

@vaind vaind marked this pull request as ready for review June 23, 2022 08:14
@vaind vaind requested a review from bitsandfoxes as a code owner June 23, 2022 08:14
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@@ -151,7 +149,7 @@ public void TryCopySymbolsToGradleProject(IApplication? application = null)
var targetPath = sourcePath.Replace(buildOutputPath, targetRoot);
_logger.LogDebug("Copying '{0}' to '{1}'", sourcePath, targetPath);

Directory.CreateDirectory(Path.Combine(Path.GetDirectoryName(targetPath)));
Directory.CreateDirectory(Path.GetDirectoryName(targetPath));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoopsie, nice catch!

@vaind vaind merged commit 50658f5 into main Jun 23, 2022
@vaind vaind deleted the feat/proguard-support branch June 23, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Proguard
2 participants