fix(onboarding-analytics): Do not fire modal closed event on configur…

…e or skip click (#77628)

With previous implementation, `onClose` function was called on every
modal closing event, including clicking on "Skip" or "Configure SDK"
button. Since those 2 events are already tracked by analytics, we wanted
to fire `project_creation.select_framework_modal_close_button_clicked`
only when close button was clicked, so the `closeModal` callback call
was removed from the functions that handle "configure sdk" and "Skip"
button clicks

Part of #77391

---------

Signed-off-by: Vjeran Grozdanic <vjeran.grozdanic@sentry.io>

static/app/components/onboarding/frameworkSuggestionModal.spec.tsx

@@ -1,5 +1,5 @@
 import {initializeOrg} from 'sentry-test/initializeOrg';
-import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
+import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
 
 import {
   makeClosableHeader,
@@ -73,8 +73,5 @@ describe('Framework suggestion modal', function () {
     expect(screen.getByRole('button', {name: 'Configure SDK'})).toBeEnabled();
 
     await userEvent.click(screen.getByRole('button', {name: 'Skip'}));
-    await waitFor(() => {
-      expect(closeModal).toHaveBeenCalled();
-    });
   });
 });

static/app/components/onboarding/frameworkSuggestionModal.tsx

@@ -209,15 +209,7 @@ export function FrameworkSuggestionModal({
     );
 
     onConfigure(selectedFramework);
-    closeModal();
-  }, [
-    selectedPlatform,
-    selectedFramework,
-    organization,
-    onConfigure,
-    closeModal,
-    newOrg,
-  ]);
+  }, [selectedPlatform, selectedFramework, organization, onConfigure, newOrg]);
 
   const handleSkip = useCallback(() => {
     trackAnalytics(
@@ -230,8 +222,7 @@ export function FrameworkSuggestionModal({
       }
     );
     onSkip();
-    closeModal();
-  }, [selectedPlatform, organization, closeModal, onSkip, newOrg]);
+  }, [selectedPlatform, organization, onSkip, newOrg]);
 
   const listEntries = [...topFrameworksOrdered, ...otherFrameworksSortedAlphabetically];