Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no attribute error #69908

Merged
merged 3 commits into from
Apr 29, 2024
Merged

fix: no attribute error #69908

merged 3 commits into from
Apr 29, 2024

Conversation

nhsiehgit
Copy link
Contributor

per https://sentry-st.sentry.io/issues/5278445518/?project=1513938

the original code type-ignored the attr-defined.

bringing that back here so we hopefully don't run into this issue again

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 29, 2024
@nhsiehgit nhsiehgit marked this pull request as ready for review April 29, 2024 18:47
@nhsiehgit nhsiehgit requested a review from a team as a code owner April 29, 2024 18:47
@nhsiehgit nhsiehgit enabled auto-merge (squash) April 29, 2024 18:47
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (7c48603) to head (8c936cd).
Report is 10 commits behind head on master.

❗ Current head 8c936cd differs from pull request most recent head cdd352d. Consider uploading reports for the commit cdd352d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #69908   +/-   ##
=======================================
  Coverage   79.84%   79.85%           
=======================================
  Files        6489     6489           
  Lines      288550   288550           
  Branches    49687    49687           
=======================================
+ Hits       230404   230408    +4     
+ Misses      57748    57744    -4     
  Partials      398      398           
Files Coverage Δ
src/sentry/api/serializers/models/alert_rule.py 98.42% <100.00%> (ø)

... and 3 files with indirect coverage changes

@nhsiehgit nhsiehgit merged commit 6965eb0 into master Apr 29, 2024
48 checks passed
@nhsiehgit nhsiehgit deleted the fix_attribute_error branch April 29, 2024 19:49
Copy link

sentry-io bot commented Apr 29, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'Rule' object has no attribute 'incident_id' /api/0/organizations/{organization_slug}/combin... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants