Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): Adds error rate to queues module #70883

Merged
merged 4 commits into from
May 15, 2024

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented May 14, 2024

Updates the Queues module to now fully display error rate in the:

  • landing page destinations table
  • destination summary metrics readout
  • destination summary transactions table
  • samples panels

Also includes a minor fix to producer/consumer sample panel readouts not showing accurate span counts.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 14, 2024
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review May 14, 2024 19:22
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner May 14, 2024 19:22
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the 1 - are a huge bummer 😢 someone's going to trip over that for sure. If there's any chance of implementing that Discover-side on the backend, it's so worth it! Otherwise LGTM

@@ -41,6 +41,7 @@ function DestinationSummaryPage() {
const destination = decodeScalar(query.destination);

const {data} = useQueuesMetricsQuery({destination});
const errorRate = 1 - (data[0]?.['trace_status_rate(ok)'] ?? 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 there's no trace_status_rate(error) for you?

Copy link
Contributor Author

@edwardgou-sentry edwardgou-sentry May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the trace context status has a bunch of different error states:
https://develop.sentry.dev/sdk/event-payloads/contexts/#trace-context

ie cancelled, unknown, invalid_argument are all possible values and are all considered errors.
Right now trace_status_rate just applies a filter for the provided status

I can update this in discover as a follow up!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Definitely worth it to define a helper for this in Discover regardless, if possible

@edwardgou-sentry edwardgou-sentry merged commit ad22def into master May 15, 2024
42 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/queues-module-error-rate branch May 15, 2024 16:13
Copy link

sentry-io bot commented May 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: useNavigate() may be used only in the context of a component. useNavigate(useNavigate.tsx) View Issue
  • ‼️ Error: useNavigate() may be used only in the context of a component. useNavigate(useNavigate.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants