feat(issues): adds backend for "resolve in upcoming release" #70990
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70990 +/- ##
===========================================
+ Coverage 61.14% 78.10% +16.96%
===========================================
Files 6508 6550 +42
Lines 289997 292399 +2402
Branches 50196 50479 +283
===========================================
+ Hits 177310 228392 +51082
+ Misses 106913 57665 -49248
- Partials 5774 6342 +568
|
| ) | ||
| .extra(select={"sort": "COALESCE(date_released, date_added)"}) | ||
| .order_by("-sort")[0] |
There was a problem hiding this comment.
what does this mean semantically, and is this still the correct behavior for "resolve in upcoming release"? (the case where there is no release passed in.)
There was a problem hiding this comment.
this query is used in a couple places to find the most recent release for a project, which we still need for this because in clear_expired_resolutions we compare the newly created release and check if there are any GroupResolution objects that have a release for a matching project that is older. if there is, then we know a new release for that project is created, so we can clear the pending GroupResolution and say the Group is resolved.
this pr makes the front end changes to support resolve in upcoming release. backend changes in #70990. the changes made include adding an option to the Resolve button on issue details (hidden behind a feature flag), adding a subtitle to the resolve dropdown to clarify behavior, and updating the resolution box to support this form of resolution. the group activities item shouldn't need any updates as it mirrors the behavior as "resolve in next release"
this pr adds the backend needed to support "resolve in upcoming release" to the ProjectGroupIndex endpoint. this differs from "resolve in next release" because it no longer does the check for if there is an immediate next release to the current release of the issue. It will still create the
GroupResolutionobject which will eventually be cleared inclear_expired_resolutionsbut this will now be the only way for it to be resolved, only when a new release is created.