feat(traces): Use new slice quantization from backend #72034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the quantization from the backend when provided (trace breakdowns), but still uses time for the spans since they don't have quantization.
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will decrease total bundle size by 59.14kB ⬇️
|
Zylphrex
approved these changes
Jun 4, 2024
mjq
reviewed
Jun 4, 2024
|
|
||
| const sliceDuration = sliceEnd - sliceStart; | ||
|
|
||
| if (sliceDuration <= 0) { | ||
| if (sliceNumberWidth === 0 && sliceNumberWidth === undefined && sliceDuration <= 0) { |
There was a problem hiding this comment.
sliceNumberWidth === 0 && sliceNumberWidth === undefined
Isn't that always false?
There was a problem hiding this comment.
Right, this should be sliceNumberWidth === 0 || (sliceNumberWidth === undefined && sliceDuration <= 0), I must have accidentally undone this.
There was a problem hiding this comment.
This should just be entirely removed anyway actually, we have checks on the backend now, don't need this defensive code anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This uses the quantization from the backend when provided (trace breakdowns), but still uses time for the spans since they don't have quantization.