Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(am2): Add project to the blended sample rate function #72900

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

wmak
Copy link
Member

@wmak wmak commented Jun 17, 2024

  • Without this we can't change the blended sample rate per project

- Without this we can't change the blended sample rate per project
@wmak wmak requested a review from a team as a code owner June 17, 2024 21:10
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2024
Copy link
Member

@k-fish k-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this why checks against projects in the sample rate function weren't working? 👍

@iambriccardo
Copy link
Member

Hi, this function won't achieve what you might expect. The project is used to get the organization id in case no organization_id is supplied. It's not the most pragmatic function signature, I am aware.

Definition is here: https://github.com/getsentry/getsentry/blob/114f2afaa986d3d5c8d70ee7c9a8f84e64ac9233/getsentry/quotas.py#L835-L835

@wmak
Copy link
Member Author

wmak commented Jun 18, 2024

@iambriccardo
Copy link
Member

@iambriccardo isn't that overriden by getsentry/getsentry@114f2af/getsentry/quotas_override.py#L168 which does use the project

Ah yeah, are you adding the projects to that list?

@iambriccardo
Copy link
Member

@wmak wmak merged commit cd5e7e5 into master Jun 18, 2024
48 checks passed
@wmak wmak deleted the wmak/feat/add-project-to-blended-rate-function branch June 18, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants