-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(am2): Add project to the blended sample rate function #72900
Conversation
wmak
commented
Jun 17, 2024
- Without this we can't change the blended sample rate per project
- Without this we can't change the blended sample rate per project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this why checks against projects in the sample rate function weren't working? 👍
Hi, this function won't achieve what you might expect. The Definition is here: https://github.com/getsentry/getsentry/blob/114f2afaa986d3d5c8d70ee7c9a8f84e64ac9233/getsentry/quotas.py#L835-L835 |
@iambriccardo isn't that overriden by https://github.com/getsentry/getsentry/blob/114f2afaa986d3d5c8d70ee7c9a8f84e64ac9233/getsentry/quotas_override.py#L168 which does use the project |
Ah yeah, are you adding the projects to that list? |
Ah okay great! All good |