fix(alerts): Prevent muting user alerts #77093
Merged
+44
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mdtro
reviewed
Sep 6, 2024
| **kwargs, | ||
| ): | ||
| args, kwargs = super().convert_args(request, user_id, *args, **kwargs) | ||
| fetched_user = kwargs["user"] |
There was a problem hiding this comment.
Rather than deriving the user from the URL, can we derive it from request.user ? That way we're restricted to just the logged in user and limits the chance of cross user queries.
There was a problem hiding this comment.
ok I tried doing that but it doesn't work due to some hybrid cloud stuff, where request.user is a lazy rpc thingy
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #77093 +/- ##
===========================================
+ Coverage 57.14% 78.18% +21.03%
===========================================
Files 6903 6914 +11
Lines 306933 307458 +525
Branches 50305 50378 +73
===========================================
+ Hits 175408 240392 +64984
+ Misses 126727 60615 -66112
- Partials 4798 6451 +1653 |
geoffg-sentry
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.