ref(integrations): Remove indirect imports from messaging integrations #77094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77094 +/- ##
===========================================
+ Coverage 57.34% 78.21% +20.87%
===========================================
Files 6976 6924 -52
Lines 309315 308015 -1300
Branches 50624 50424 -200
===========================================
+ Hits 177368 240913 +63545
+ Misses 127085 60680 -66405
- Partials 4862 6422 +1560 |
This reverts commit 5117fe8.
iamrajjoshi
approved these changes
Sep 12, 2024
| @@ -18,7 +18,9 @@ | |||
| IssueAlertNotificationMessageRepository, | |||
| ) | |||
| from sentry.integrations.slack.message_builder.base.block import BlockSlackMessageBuilder | |||
| from sentry.integrations.slack.message_builder.notifications import get_message_builder | |||
There was a problem hiding this comment.
we should audit if we even need this service
cathteng
approved these changes
Sep 12, 2024
RyanSkonnord
deleted the
cleanup-messaging-integration-indirect-imports
branch
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
#77094) Delete star-imports with "noqa: F401,F403" and update related import statements. Move declarations from `__init__.py` to other files.
RyanSkonnord
added
the
Trigger: Revert
|
PR reverted: b797f51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete star-imports with "noqa: F401,F403" and update related import statements. Move declarations from
__init__.pyto other files.