Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggml-alloc : remove buffer_id from leaf_alloc #987

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Oct 9, 2024

This commit removes the buffer_id field from the leaf_alloc struct.

The motivation for is that this field is only written to and never read/used as far as I can tell. Each tensor_alloc has a buffer_id field and this is what caused me to look into this more closely, to understand what the buffer_id in leaf_alloc was used for.

This commit removes the buffer_id field from the leaf_alloc struct.

The motivation for is that this field is only written to and never
read/used as far as I can tell. Each tensor_alloc has a buffer_id field
and this is what caused me to look into this more closely, to
understand what the buffer_id in leaf_alloc was used for.
@slaren
Copy link
Collaborator

slaren commented Oct 9, 2024

Yes this is correct. At some point buffer_id was moved to tensor_alloc from node_alloc and leaf_alloc, but leaf_alloc was not updated.

@slaren slaren merged commit 2327bda into ggerganov:master Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants