Interface configuration

[simher]

Hi!

I have added some code to be able to use the interface directive in the ntp.conf.

Does it look Ok to you?

Best regards,
Simon

[ghoneycutt]

The docs read that the format should be interface <action> <address> whereas your code only has one argument to interface. Since there can be multiple interface lines, perhaps we should use a hash.

Example:

$interfaces = {
  'ignore' => 'ipv6',
  'listen' => '127.0.0.1',
}

https://www.mankier.com/5/ntp_misc

[ghoneycutt]

instead of UNSET we could use {}

[ghoneycutt]

What do you think? We also need spec tests, but I'm happy to help with those.

[simher]

Yes I know, In hiera I have configured it the following way,

ntp::interface:
-ignore wildcard
-listen 10.132.172.85/20

And I don't really understand your example. Should It look like this then?

ntp::interface_ignore: 'wildcard'
ntp::interface_listen: '10.132.172.85/20'
ntp::interface_drop: 'all'

Seems just more of an annoyance and less readable.

Or am I missing something?

[ghoneycutt]

Please not that this must be an array of strings and give an example.

[ghoneycutt]

This is separate from adding the interface parameter and should be in its own pull request.

I noticed you are using your master branch instead of creating a topic branch. Suggest creating a topic branch so this can be separate from the interface pull request (PR).