Add improvements to styleguide #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment they're displayed on a single line.
The old styleguide page [1] points to the Rubocop styleguide as a source of inspiration. Let's add it here as well. [1]: https://web.archive.org/web/20160410033955/https://github.com/styleguide/ruby
This doesn't add or remove any rules, it just groups them together under: Layout - Indentation - Inline - Newlines Maximum Line Length Inspired by the RuboCop [1] and AirBnb [2] styleguides. [1]: https://github.com/rubocop/ruby-style-guide/blob/master/README.adoc [2]: https://github.com/airbnb/ruby/blob/master/README.md
I've noticed people point at the styleguide when doing reviews. Let's make their life easier by adding a link to each rule. Spoiler: I am one of those people.
elenatanasoiu
force-pushed
the
elenatanasoiu/style-the-styleguide
branch
from
cbf5700
to
653e004
Compare
cheshire137
approved these changes
Aug 30, 2022
jhawthorn
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Please review this PR commit-by-commit.
While looking into which of our styleguide rules are represented by Rubocop rules, I thought I'd take the time to add some improvements:
NB: This PR doesn't add or remove any rules.