Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upgraded pip in test fixture virtual environment #1864

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Use upgraded pip in test fixture virtual environment #1864

merged 2 commits into from
Mar 11, 2024

Commits on Mar 11, 2024

  1. Start fixing venv test fixture pip toml bug 

    This is not yet a usable fix, because venv.create only supports
upgrade_deps on Python 3.9 and higher.
    @EliahKagan
    EliahKagan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    dd8ee4f View commit details
    Browse the repository at this point in the history

  2. Upgrade test fixture pip in venv without upgrade_deps 

    Because the upgrade_deps parameter to venv.create, as well as
related functionality such as the EnvBuilder.upgrade_dependencies
method that it uses, are only available starting in Python 3.9.

This also puts the name of the VirtualEnvironment.__init__
parameter for setting up pip in the test fixture virtual
environment back from need_pip to with_pip, which may be more
intuitive.
    @EliahKagan
    EliahKagan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a262a06 View commit details
    Browse the repository at this point in the history