Add HTML::Proofer#failed_tests #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general I'm all about adding stuff to help other people. 😃 I'm mostly curious what this would be used for, though. How is it helpful to know just which tests failed? |
|
Mostly to make testing easier. Capturing STDOUT for all of them has made debugging confusing at times. |
gjtorikian
added a commit
that referenced
this pull request
May 27, 2014
Add HTML::Proofer#failed_tests
|
Released as 0.7.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a selfish PR in that it would make retrieving errors by external modules easier (see afeld/markdown_proofer#8), but I do think some refactoring could be done to clean up the code around passing errors and checking them in the specs. 👶 step 😉