Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaking handler in date format setup #806

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

SlexAxton
Copy link
Contributor

A coworker of mine patched this locally because we were experiencing progressive slow-downs the more we rendered certain pages with lots of dates.

They are adding and removing an event listener from cldr when we pass in options.timeZone, but since they are constructing the listener with a generator function, they aren't actually removing the one they added. I'll see if I can modify this function and check if that fixes it.

<3z,
Alex

@jsf-clabot
Copy link

jsf-clabot commented Mar 9, 2018

CLA assistant check
All committers have signed the CLA.

In certain situations we weren't always cleaning up an event handler for
date formatting. This commit ensures that we do.
@rxaviers
Copy link
Member

rxaviers commented Mar 9, 2018

Thanks! ❤️

@rxaviers rxaviers merged commit b77f35f into globalizejs:master Mar 9, 2018
@rxaviers
Copy link
Member

rxaviers commented Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants