Feature : 회원 정보 수정 - 성격 api 구현 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labeler가 제목과 설명에 있는 특별한 텍스트와 일치하는 레이블을 적용했습니다. |
kangju2000
reviewed
Aug 28, 2023
Comment on lines
85
to
86
| if (status === 'personalities') | ||
| return <PersonalityEditPage onClose={() => setStatus('profile')} />; |
There was a problem hiding this comment.
InputForm 컴포넌트 안에 personality 페이지 분기처리 로직이 들어가있네요?
리턴되는 컴포넌트들의 추상화 레벨이 다른 것 같아요!
하나는 PersonalityEditPage라는 페이지 컴포넌트 (높은 추상화),
다른 하나는 폼 컴포넌트 (중간 추상화)
라고 생각이 되는데, 폼 컴포넌트를 따로 페이지로 빼두어서 이 컴포넌트를 페이지 분기 처리하는 컴포넌트로 만들어 두면 더 좋을 것 같습니당
There was a problem hiding this comment.
// ProfileEdit.client.tsx
const [step, setStep] = useState(1);
const { data: defaultProfileData } = useGetProfile();
<EditProvider defaultValues={defaultProfileData}>
{step === 1 && <Step1 onNext={() => setStep(2)} />}
{step === 2 && <Step2 onPrev={() => setStep(1)} />}
</EditProvider>위와 같이 ProfileEdit컴포넌트에서 Step1,2로 상태값을 관리하여 렌더링하는 방식으로 바꾸었습니다. 데이터를 한 번만 fetch해오고, defaultValue로 설정하는 방식으로 하여 추상화를 맞추었습니다 ~!
guesung
changed the title
guesung
added a commit
that referenced
this pull request
Jul 12, 2024
[Feature] 회원 정보 수정 - 성격 api 구현
guesung
added a commit
that referenced
this pull request
Jul 17, 2024
[Feature] 회원 정보 수정 - 성격 api 구현
guesung
added a commit
that referenced
this pull request
Jul 17, 2024
[Feature] 회원 정보 수정 - 성격 api 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
💬 리뷰어분들께