Feature : 모임 멤버 조회 페이지 리팩토링 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labeler가 제목과 설명에 있는 특별한 텍스트와 일치하는 레이블을 적용했습니다. |
guesung
approved these changes
Aug 30, 2023
| import Image from 'next/image'; | ||
|
|
||
| export default function TopSection() { | ||
| const { groupId } = useNumberParams<['groupId']>(); | ||
| const { contentRef, setShowFullText, shouldShowButton, showFullText } = useShowMore({ |
There was a problem hiding this comment.
p4)
setShowFullText은 boolean값을 true <-> false를 변환해주는 역할밖에 하지 않는 것 같은데, setShowFullText가 아니라, toggleShowFullText를 넘겨주면 어떨까요 ?
Comment on lines
+22
to
+28
| useEffect(() => { | ||
| if (contentRef.current) { | ||
| const lineHeight = parseInt(getComputedStyle(contentRef.current).lineHeight, 10); | ||
| contentRef.current.style.maxHeight = showFullText ? 'none' : `${lineHeight * maxLines}px`; | ||
| contentRef.current.style.overflow = showFullText ? 'visible' : 'hidden'; | ||
| } | ||
| }, [showFullText, maxLines]); |
There was a problem hiding this comment.
ref를 넘겨줌으로써 style등의 DOM 조작을 ref를 생성한 useShowMore에서 할 수 있군요 ..! 👍👍
|
|
||
| return ( | ||
| <section> | ||
| <h2 className="pl-4 text-subtitle-3 text-sign-secondary">모임 위치</h2> | ||
| <Spacing size={4} /> | ||
| <div className="relative rounded-8 bg-gray6"> | ||
| <div className="relative rounded-8 bg-gray6" onClick={handleClipboardClick}> |
There was a problem hiding this comment.
p1)
onClick위치가 Image가 아니라, div전체에 주고 있어요 !
guesung
pushed a commit
that referenced
this pull request
Jul 12, 2024
…-member-page Feature : 모임 멤버 조회 페이지 리팩토링
guesung
pushed a commit
that referenced
this pull request
Jul 17, 2024
…-member-page Feature : 모임 멤버 조회 페이지 리팩토링
guesung
pushed a commit
that referenced
this pull request
Jul 17, 2024
…-member-page Feature : 모임 멤버 조회 페이지 리팩토링
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
💬 리뷰어분들께