Page : 피드백 페이지 #326
Merged
Page : 피드백 페이지 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labeler가 제목과 설명에 있는 특별한 텍스트와 일치하는 레이블을 적용했습니다. |
kangju2000
approved these changes
Sep 1, 2023
| <Flex align="center"> | ||
| <Avatar size="medium" imageUrl={imageUrl} /> | ||
| <Spacing size={12} direction="horizontal" /> | ||
| <div className="flex grow flex-col justify-center"> |
There was a problem hiding this comment.
p2) Flex 컴포넌트 사용하는게 좋을 것 같아요!
Comment on lines
+153
to
+156
| groupMemberList: Array<{ | ||
| imageUrl: string; | ||
| name: string; | ||
| }>; |
There was a problem hiding this comment.
GroupMember 인터페이스가 있으니 서버에서 GroupMember 형태로 가져오도록 백엔드분들께 요청해서 타입 통일하는게 좋아보여요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
💬 리뷰어분들께