Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : 자잘한 이슈 해결 #490

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Feature : 자잘한 이슈 해결 #490

merged 3 commits into from
Oct 17, 2023

Conversation

guesung
Copy link
Member

@guesung guesung commented Oct 17, 2023

💡 왜 PR을 올렸나요?

💁 무엇이 어떻게 바뀌나요?

  1. 인증번호 오지 않아도 인증번호 창 우선 뜨도록
  2. 언어 바꾸지 않으면 언어 변경 버튼 비활성화

@github-actions
Copy link

Labeler가 제목과 설명에 있는 특별한 텍스트와 일치하는 레이블을 적용했습니다.
Label을 검토하고 필요한 변경 사항을 적용해 주세요.

@github-actions github-actions bot added the Feature 기존 페이지/컴포넌트에서 기능을 추가한 경우 label Oct 17, 2023
@guesung guesung changed the title Feature/480 issue Feature : 자잘한 이슈 해결 Oct 17, 2023
@github-actions
Copy link

Bundle Sizes

Compared against none

Route Size (gzipped)
/_app 108.79 KB
/_error 75.59 KB

Dynamic import: None found.

Copy link
Contributor

@kangju2000 kangju2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


const [language, setLanguage] = useState(getLocalCookie('i18next') || 'en');
const prevLanguage = getLocalCookie('i18next');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cookieName 임포트해서 넣어주세요!
그리고 지금 'react-i18next'의 useTranslation가 임포트되어 있어 직접 커스텀한 것으로 변경 부탁드립니당

@guesung guesung merged commit acab417 into develop Oct 17, 2023
1 check passed
@guesung guesung deleted the feature/480-issue branch October 17, 2023 10:12
guesung added a commit that referenced this pull request Jul 12, 2024
Feature : 자잘한 이슈 해결
guesung added a commit that referenced this pull request Jul 17, 2024
Feature : 자잘한 이슈 해결
guesung added a commit that referenced this pull request Jul 17, 2024
Feature : 자잘한 이슈 해결
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 기존 페이지/컴포넌트에서 기능을 추가한 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants