Upgrade Dependencies #212
Merged
Upgrade Dependencies #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alteous
reviewed
Apr 1, 2019
| .map(|f| f.ident.as_ref().unwrap()) | ||
| .map(|ident| { | ||
| use inflections::Inflect; | ||
| let field = ident.as_ref().to_camel_case(); | ||
| let field = ident.to_string().to_camel_case(); |
There was a problem hiding this comment.
Using .as_ref() to get a str was removed in syn 0.13, because proc_macro2 0.4 removed their Ident AsStr impl, as the normal proc_macro crate removed their AsStr impl, the rationale for which is explained here.
Using .to_string() is now the only supported way to get the name of the identifier.
alteous
reviewed
Apr 1, 2019
|
|
||
| [dependencies.image] | ||
| default-features = false | ||
| features = ["jpeg", "png_codec"] |
|
Thanks for your PR! The changes to the image crate are good. Adding The parallel JPEG decoding feature is OK but I would prefer it to be opt-in, that is, not enabled by default. |
This causes a minor break in backwards compatibility, due to images own break, involving the Format enum. Also, only require features necessary to support standard-required formats (jpg+png, see specification/2.0/schema/image.schema.json). A convenience feature to enable parallel JPEG decoding is also added.
|
Parallel JPEG decoding was only enabled by default because it had been in I also fixed the alphabetization on the third commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following outdated dependencies, and fixes the resulting incompatibilities:
approx, 0.1.1 -> 0.3base64, 0.6 -> 0.10cgmath, 0.15 -> 0.17image, 0.19 -> 0.21lazy_static, 0.2 -> ^1quote, 0.3 -> 0.6syn, 0.11 -> 0.15Updating
quoterequires adding a dependency onproc_macro2togltf-derive, butgltf-jsonalready transitively requires that anyways.Updating
imageis slightly complicated by their adding of BGR pixel formats to theimage::DynamicImageenum. The current PR just adds the new formats togltf::image::Format, though you could, to preserve backwards compatibility, alternatively not add them and report some sort of error when encountered; or, to ensure forwards compatibility, add a hidden __Nonexhaustive variant (see RFC 2008 to prevent exhaustive matching.Additionally, this only asks for
imagefeatures required by the glTF spec (that is, support for PNG and JPEG images), so as to decrease unused code size if someone is not usingimageexcept throughgltf.imagesjpeg_rayonparallel JPEG decoding feature is also enabled by default for convenience. Alternatively, of course, we could not do this.