Choose exact transition match if available #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcockwell
requested review from
coryb,
mikepea and
vanniktech
as code owners
coryb
requested changes
Sep 30, 2019
|
not sure what is up with the tests, looks unrelated to your changes, I will look into that when I get a chance. |
coryb
approved these changes
Oct 1, 2019
|
@coryb Any idea how long this will be before it makes it into a new release? Just curious so I can check back when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #281 by attempting to choose the exact match if possible.
I am reasonably new to
go, but believe I have implemented this correctly. That being said, I was unable to determine where the tests for this are written, as well as how to execute those tests. Please feel free to request or make changes as needed, though if you want me to do them you'll have to provide some detail in your instructions so I can understand what you need.