Try to fix Thrift failure (again) #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
don't get me started on thrift... most of my issue reports for |
peterbourgon
pushed a commit
that referenced
this pull request
Dec 3, 2017
* cmd/kitgen: parse * First stymie * Sketch developing * Broken sketch. * Further progress - still doesn't build * Need to collect ast.Exprs, not strings * Running downhill. * sd: add Stop method to Instancer interface Every implementation (modulo mock/test impls) already provided this method, and so it makes sense to lift it to the interface definition. Closes #566. * Fruitful avenue. Committing for travel. * Needs uniquify for varnames * Track gauge values and support default tags for dogstatsd Dogstatsd doesn't support sending deltas for gauges, so we must maintain the raw gauge value ourselves. * Service generation tests work * add failing test for cloudwatch metrics, that are not reset * Refactor cloudwatch: Reset().Walk() on every Send(), like influx impl does. Note there is a breaking API change, as the cloudwatch object now has optional parameters. * Tolerate that there may not be any lables, if the teststat.FillCounter() did not add any samples. * Use Cloudwatch options in the struct itself, which is cleaner * sd: fix TestDefaultEndpointer flake, hopefully * util/conn: more detail for flaky test * removed deprecated functions changed `NewContext -> NewOutgoingContext` and `FromContext -> FromIncomingContext` as described in [metadta](https://github.com/grpc/grpc-go/blob/master/metadata/metadata.go) * Functions extracted from inline codefile * Cleaner/easier way for user to specify Cloudwatch metric percentiles. * fix test to read quantile metrics with p prefix * test cloudwatch.WithPercentiles() * Handles anonymous fields for all parts of interface * Handles underscore param names, produces compile-able code * do not prefix metrics with 'p', just like it was previously. * Fix for dogstatsd metrics with default tags and no labelValues Signed-off-by: James Hamlin <james@goforward.com> * Converted flat to a layout - proceeding to implement default * Convenience function for formatting to a tree * Fix spelling of deregisters https://en.wiktionary.org/wiki/deregister * Add basic auth middleware * Default layout * Need to handle mutating trees more effectively to do default layout. * Basic Auth: optimize memory allocation. * Fix typo * cache required creds' slices * Clean up comment * Replacing idents successfully * improve error handling and style * Constructs import paths usefully * Some debugging - transit * Set time unit on metrics.Timer * Changes as per code review * fix missing comma in example histogram code * update_deps.bash: handle detached HEAD better * .travis.yml: go1.9 + tip exclusively * circle.yml: go1.9 exclusively * Selectify works - need to rearrange some idents now * Updating golden masters so that they build * Nearly 100% functionality * Updated masters - all seems to work * Now testing that everything builds * Removing AST experiments * Chopping up long sourcecontext.gog * Tiny little notes * auth/jwt: add claim factory to example * auth/jwt: minor gofmt fixes * fix typo in addcli * Cleaning up some type assertion digging * Remove dependency on juju * Downstream usages of ratelimit package * Recreating profilesvc issue * Adding .ignore for rg * flat layout works with defined types * Default layout mostly works - one remaining selectify issue * Debugging replaces - determined we need to do cloning * Halfway through an edit - taking it home * Works with new profilesvc testcases * Try to fix Thrift failure (again) (#630) * Empty commit to trigger CI * examples/addsvc: rebuild with latest thrift * cmd/kitgen: parse * First stymie * Sketch developing * Broken sketch. * Further progress - still doesn't build * Need to collect ast.Exprs, not strings * Running downhill. * Fruitful avenue. Committing for travel. * Needs uniquify for varnames * Service generation tests work * Functions extracted from inline codefile * Handles anonymous fields for all parts of interface * Handles underscore param names, produces compile-able code * Converted flat to a layout - proceeding to implement default * Convenience function for formatting to a tree * Default layout * Need to handle mutating trees more effectively to do default layout. * Replacing idents successfully * Constructs import paths usefully * Some debugging - transit * Selectify works - need to rearrange some idents now * Updating golden masters so that they build * Nearly 100% functionality * Updated masters - all seems to work * Now testing that everything builds * Removing AST experiments * Chopping up long sourcecontext.gog * Tiny little notes * Cleaning up some type assertion digging * Recreating profilesvc issue * Adding .ignore for rg * flat layout works with defined types * Default layout mostly works - one remaining selectify issue * Debugging replaces - determined we need to do cloning * Halfway through an edit - taking it home * Works with new profilesvc testcases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😠