feat: greatly improve capabilities of delete queries #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
force-pushed
the
feat/join-on-delete
branch
from
5d9f7e1
to
deb4cc3
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 45+7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
Allow using any
.Join(), pagination, or whatever capabilities in delete queries.What are the main choices made to get to this solution?
Using a select sub-query because it works on any database. The sub-query relies on the assumption that a record only has a unique primary key. Composite keys can cause too many records to be deleted. Similar problems also occur in other parts of the codebase.
List the manual test cases you've covered before sending this PR:
None, "only" automated tests.