Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default destructor for Object #626

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Use default destructor for Object #626

merged 1 commit into from
Sep 28, 2021

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Sep 27, 2021

Minor style improvement, follows up #27. Was suggested by @vnen.

@Calinou Calinou added the enhancement This is an enhancement on the current functionality label Sep 27, 2021
@Shatur Shatur mentioned this pull request Sep 27, 2021
Closed
@akien-mga akien-mga changed the title Use = default Use default destructor for Object Sep 28, 2021
@akien-mga
Copy link
Member

Please amend the commit message to be more explicit (e.g. like I did with the PR itself).

@Shatur
Copy link
Contributor Author

Shatur commented Sep 28, 2021

Done!

@akien-mga akien-mga added this to the 4.0 milestone Sep 28, 2021
@akien-mga akien-mga merged commit 5826fd5 into godotengine:master Sep 28, 2021
@akien-mga
Copy link
Member

Thanks!

@Shatur Shatur deleted the use-default branch September 28, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Shatur @akien-mga @Calinou