Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix const qualifier for parameters in GDExtension api functions #897

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Fix const qualifier for parameters in GDExtension api functions #897

merged 1 commit into from
Dec 3, 2022

Conversation

touilleMan
Copy link
Member

@touilleMan touilleMan force-pushed the gdextension-fix-gdnative-types-const-qualifier branch 2 times, most recently from 26c67d5 to 932b43f Compare October 23, 2022 07:31
@touilleMan touilleMan force-pushed the gdextension-fix-gdnative-types-const-qualifier branch from 932b43f to 1a6a03d Compare November 12, 2022 22:56
@touilleMan touilleMan mentioned this pull request Nov 12, 2022
Merged
@touilleMan touilleMan force-pushed the gdextension-fix-gdnative-types-const-qualifier branch from 1a6a03d to ae73008 Compare November 12, 2022 22:58
@touilleMan
Copy link
Member Author

rebased ;-)

@touilleMan touilleMan force-pushed the gdextension-fix-gdnative-types-const-qualifier branch 4 times, most recently from 5e04506 to d743165 Compare November 12, 2022 23:50
@Calinou Calinou added bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation labels Nov 13, 2022
groud
groud approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in GDExtension PR review.

@touilleMan touilleMan force-pushed the gdextension-fix-gdnative-types-const-qualifier branch from d743165 to ef5b327 Compare December 2, 2022 22:27
@touilleMan touilleMan force-pushed the gdextension-fix-gdnative-types-const-qualifier branch from ef5b327 to fe86a94 Compare December 2, 2022 23:27
@touilleMan touilleMan merged commit 32859ea into godotengine:master Dec 3, 2022
@touilleMan touilleMan deleted the gdextension-fix-gdnative-types-const-qualifier branch December 3, 2022 10:14
@Daylily-Zeleen Daylily-Zeleen mentioned this pull request Dec 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud groud approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@touilleMan @groud @Calinou